> Jan, when will you apply the patch I delivered to the code in SVN?
I'm looking at it, but as you have seen from my comments on the issue there are some problems and until I can solve them all the code will not be committed. It needs to be working for clean installation and also for upgrades. That is the very minimum. The error I'm seeing right now on the dialog when creating subtype needs to go as well. There are few more things that need to change before release (e.g. the root path for the subtypes), but those I can do after the commit. However I do not want to hold you from other work. I think you can keep working on the code, just keep noting somewhere what changes are you making and why which would make merging of the code for me easier. > > The way activation is configured now seems to force the user to work with > workflow. 'Direct' activation is not possible without config changes, am I > right? Yes, as of data module 1.4, the workflow is enabled for the module by default. If you want to disable this, the same instructions as for disabling workflow in other workspaces apply. > > Bye, Bert > > > -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of Jan Haderka > Sent: dinsdag 29 september 2009 9:14 > To: Magnolia Dev-List > Subject: Re: [magnolia-dev] datamodule type activation issues > > > > > > > NOT created are the dialog and the tree for this type. Option: maybe > > the dialog can be activated too, together with the type. Not sure if > > this is really necessary. If the dialog is needed at public it can be > > I've always thought that no one need to see the data maintained by the > data module on public, but since this is not the first time i hear this > question, I'm probably wrong. > > > activated manually. The creation of the tree could be moved from the > > dialoghandler to the DataModule. This way the tree is created > > I'm very tempted to say, yes, let's move it since I don't like the > dialogHandler creating the tree. > In theory, even if you adapt the tree and/or the dialog you can always > activate it, but ... if they were generated on the public as well, > rather then activated, they would exist there with different uuids which > is something i would rather avoid. Also having user to activate the > dialog and tree explicitly (even if they modified it) is not very nice. > For this reason I would think that perhaps the best solution to the > issue is to have a custom activate command for the type that would in > same go activate also the tree, the menu and the dialog for given type > so it is treated as a bundle of related things which is what it really > is. > > Jan > > > automatically when the type is activated. It is not very likely that > > the tree definition was adapted at the author side. The dialog > > definition most likely has. > > > > > > > > Your views on this matter are appreciated, as always! > > > > > > > > Best regards, Bert > > > > > > > > > > > > > > > > ______________________________________________________________________ > > ---------------------------------------------------------------- > > For list details see > > http://www.magnolia-cms.com/home/community/mailing-lists.html > > To unsubscribe, E-mail to: <[email protected]> > > ---------------------------------------------------------------- > > > ---------------------------------------------------------------- > For list details see > http://www.magnolia-cms.com/home/community/mailing-lists.html > To unsubscribe, E-mail to: <[email protected]> > ---------------------------------------------------------------- > > > ---------------------------------------------------------------- > For list details see > http://www.magnolia-cms.com/home/community/mailing-lists.html > To unsubscribe, E-mail to: <[email protected]> > ---------------------------------------------------------------- ---------------------------------------------------------------- For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: <[email protected]> ----------------------------------------------------------------
