[
http://jira.magnolia-cms.com/browse/MGNLDATA-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=24341#action_24341
]
Jan Haderka commented on MGNLDATA-68:
-------------------------------------
The patch is committed now. Few technical comments:
- when creating a patch, do it against the current trunk not against the trunk
at the time of first checkout (i.e. do the local mere before creating the
patch). This way you can be sure that your latest changes will still work after
the merge and make also review faster.
- when changing public or protected methods, keep in mind that there might be
someone else using them. Any public or protected code has to be deprecated for
one major version before it can be finally removed. When deprecating something,
make sure the message contains info about since the code is deprecated and if
there is a replacement for it, also link to it. I have restored all the
public/protected methods that were removed by the patch.
- few more inline comments at some more complex blocks of code would be
helpful. It is better to have too much of the comments then too little (i'm
told i write too little of comments all the time too ;) )
- the tests would be very much appreciated and would ensure that the behavior
doesn't change accidentally when other changes are made to the module in the
future.
> Allow creation of types and data nodes in a hierarchy.
> ------------------------------------------------------
>
> Key: MGNLDATA-68
> URL: http://jira.magnolia-cms.com/browse/MGNLDATA-68
> Project: Magnolia Data Module
> Issue Type: Improvement
> Affects Versions: 1.4
> Reporter: Bert Leunis
> Assignee: Jan Haderka
> Attachments: magnolia-module-data.patch
>
>
> See this entry in the wiki for the description of the desired functionality:
> http://wiki.magnolia-cms.com/display/DEV/Magnolia+Data+Module+Extensions+-+Mixed+type+hierarchies.
> There are many changes to accommodate the new functionality. Here are the
> main changes:
> - Many classes that create, delete, display the types or the nodes are
> touched to accommodate the new structure.
> - the DataModule now stores the typedefinitions
> - DataModule creates only one menu entry per rootpath
> - the title of the menu entry can be given in the type definition (sometimes
> the root type does not explain the main content of a type tree)
> - TypeDeleteCommand: I am not sure if this ever worked correctly. Should do
> now, and also deletes the tree belonging to the type.
> - TypeDialog: rootpath, allow folders, sort by name are only to be edited in
> the root type
> - new TypeSelectDataDialog: when creating a new type, will check if there are
> multiple options of types to create
> - TypeAdminTree and GenericDataAdminTree: lot of new code
> - When working with folders: they are only allowed at the root, not within
> the type trees itself
> - When items are moved or copied within the tree, if the type definition
> structure would be broken, the move/copy is prevented.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------
