[
http://jira.magnolia-cms.com/browse/MGNLDATA-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=24344#action_24344
]
Bert Leunis commented on MGNLDATA-68:
-------------------------------------
Thanks for all the work Jan, and apologies for all the inconveniences.
- for such a big change of the code, using a userid/password directly to the
svn would give a better way to work maybe
- having a magnolia code style formatter and using the maven checkstyle plugin
can prevent some of the problems you experienced
- having been lectured on writing 'clean code' I limited the number of comments
a bit too much it seems. I like to write comments, if only for myself, to know
what I ment to do when reviewing my own code later on.
- sorry about the tests. not very experienced writing tests, and a collegue of
mine told me that writing tests for magnolia is quite hard, for example through
the use of all the statics. So I was not very much encouraged.
> Allow creation of types and data nodes in a hierarchy.
> ------------------------------------------------------
>
> Key: MGNLDATA-68
> URL: http://jira.magnolia-cms.com/browse/MGNLDATA-68
> Project: Magnolia Data Module
> Issue Type: Improvement
> Affects Versions: 1.4
> Reporter: Bert Leunis
> Assignee: Jan Haderka
> Attachments: magnolia-module-data.patch
>
>
> See this entry in the wiki for the description of the desired functionality:
> http://wiki.magnolia-cms.com/display/DEV/Magnolia+Data+Module+Extensions+-+Mixed+type+hierarchies.
> There are many changes to accommodate the new functionality. Here are the
> main changes:
> - Many classes that create, delete, display the types or the nodes are
> touched to accommodate the new structure.
> - the DataModule now stores the typedefinitions
> - DataModule creates only one menu entry per rootpath
> - the title of the menu entry can be given in the type definition (sometimes
> the root type does not explain the main content of a type tree)
> - TypeDeleteCommand: I am not sure if this ever worked correctly. Should do
> now, and also deletes the tree belonging to the type.
> - TypeDialog: rootpath, allow folders, sort by name are only to be edited in
> the root type
> - new TypeSelectDataDialog: when creating a new type, will check if there are
> multiple options of types to create
> - TypeAdminTree and GenericDataAdminTree: lot of new code
> - When working with folders: they are only allowed at the root, not within
> the type trees itself
> - When items are moved or copied within the tree, if the type definition
> structure would be broken, the move/copy is prevented.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------
