[ 
http://jira.magnolia-cms.com/browse/MAGNOLIA-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=28830#action_28830
 ] 

Philipp Bärfuss edited comment on MAGNOLIA-3234 at 6/24/10 10:21 AM:
---------------------------------------------------------------------

Federico says:
{quote}
Basically it works, just need to write the update tasks. However, yesterday 
Greg had a quick look at the implementation and raised some doubts:

1) extra logic in AbstractRenderer
2) throwing an Exception when a templatePath was null was a good hint in case 
of template definition misconfigurations 
3) the resources module now is dependent on 4.3.3

What he proposed was to use a special new Renderer for the redirect template
{quote}

      was (Author: pbaerfuss):
    {quote}
Basically it works, just need to write the update tasks. However, yesterday 
Greg had a quick look at the implementation and raised some doubts:

1) extra logic in AbstractRenderer
2) throwing an Exception when a templatePath was null was a good hint in case 
of template definition misconfigurations 
3) the resources module now is dependent on 4.3.3

What he proposed was to use a special new Renderer for the redirect template
{quote}
  
> Make it possible to skip rendering
> ----------------------------------
>
>                 Key: MAGNOLIA-3234
>                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3234
>             Project: Magnolia
>          Issue Type: Task
>          Components: templating
>            Reporter: Federico Grilli
>            Assignee: Federico Grilli
>             Fix For: 4.3.3, 5.0
>
>
> When realizing the new redirect functionality the need arose for skipping the 
> rendering of templates under certain conditions. This can be achieved by 
> skipping the call to the onRender(..) method in AbstractRenderer.render(..) 
> method when the determineTemplatePath(..) method for a certain template 
> returns null. So far, this caused an IllegalStateException but now this 
> should not be the case anymore and a null templatePath would simply mean 'do 
> not render anything'.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------

Reply via email to