![]() |
|
|
|
|
Change By:
|
Grégory Joseph
(01/Oct/13 6:46 PM)
|
|
Description:
|
When trying to put the new i18n system in place
Fixes
for
MGNLUI-2135 are unsatisfactory.
One of
the
workflow module I realised
reasons is
that
many keys I expected the system
some presenters pass an already-decorated definition
to
generate weren
info.magnolia.ui.dialog.BaseDialogPresenter#start, and some don
't
actually generated
. After an initial analysis with [@pbaerfuss]
,
for example
we thought we'd move that responsibility to
the
keys for save and cancel buttons are never created or the field labels in forms and dialogs
caller
. After
some
further
investigation
:
* There are "too many" places where this should occur
,
it turned out that forms
and
dialogs haven't been properly decorated, i.e.
that would somewhat hide/obscure
the calls to
{{
I18nizer.
decorate
* DialogPresenter#start does not make sense as an interface method. Every presenter reimplements a start
()
}} are either missing or put in the wrong place. After putting them in the right spots so that the whole object hierarchy is properly decorated, the AbstractFormKeyGenerator has started failing
method
with
some NPE which need to be fixed. Furthermore, we miss a KeyGenerator for FieldValidatorDefinition
their specific argument
(
s
see sub-interfaces
)
. The reason why everything apparently works now
,
i.e. most stuff
so it
is
basically translated is because translations are currently hardcoded in configuration but once we clean config up and remove labels, descriptions and other i18n properties then the problem would become apparent
never a real entry point
.
|
|
|
|
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
----------------------------------------------------------------
For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: <
[email protected]>
----------------------------------------------------------------
