![]() |
|
|
|
|
Change By:
|
Grégory Joseph
(02/Oct/13 12:09 PM)
|
|
Description:
|
Fixes for MGNLUI-2135 are unsatisfactory.
One of the reasons is that some presenters pass an already-decorated definition to info.magnolia.ui.dialog.BaseDialogPresenter#start, and some don't. After an initial analysis with [@pbaerfuss], we thought we'd move that responsibility to the caller. After further investigation:
* There are "too many" places where this should occur, and that would somewhat hide/obscure the calls to I18nizer.
* DialogPresenter#start does not make sense as an interface method. Every presenter reimplements a start() method with their specific argument (see sub-interfaces), so it is never a real entry point.
BaseDialogPresenter#getI18nizer should not be there.
The definition passed to {{info.magnolia.ui.dialog.BaseDialogPresenter#start}} should be already decorated. (tried to get to that but failed)
|
|
|
|
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
----------------------------------------------------------------
For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: <
[email protected]>
----------------------------------------------------------------
