On Feb 7, 2007, at 14:28 , Fabrizio Giustina wrote:
On 2/7/07, Grégory Joseph <[email protected]> wrote:
On Feb 7, 2007, at 08:56 , Fabrizio Giustina wrote:
> it's the same issue I had in the past traced in
> http://jira.magnolia.info/browse/MAGNOLIA-1229#action_13068
Come on Fabrizio, it's still marked resolved, since last december...
We need to keep track of changes.
well, unfortunately I didn't had an occasion to test it before, after
you marked it as resolved. Unfortunately it seems that your changes
didn't really fix it for me...
That's fine, but in such cases we should reopen or create new issues/
link ;)
plugin-specific dependencies never end up in the final war,
Sure, that was just a general remark, since there are a couple of
unnecessary jars in the final war (thanks for excluding some recently
btw;))
and anyway
those deps are simply a duplication of something that should already
be in the jspc plugin classpath.
As far as I can read the jspc plugin's pom, if you're using jdk1.4,
you'll get the tomcat5.5 jars on your CP - maybe those don't declare
the servlet api jars as transitive deps. If you're usind jdk5, then
you get tomcat6 and geronimo spec jars. Maybe that's also where the
problem lies... ?
is that the issue is probably somewhere else, and that's what should
really be fixed. By bringing the attention of the list to the issue,
you might get suggestions/ideas or a "oh well, yeah, let's just add
these deps". But at least everyone will be aware of the issue and
that might help "by accident" (by dragging my attention to some blog
post relating the same issue I'd have ignored otherwise, for
instance)
This is just intended to be a patch that let me (and others) at least
build magnolia for now. The problem is not in magnolia but in maven or
in the jspc plugin: I am also a committer for both of them and so I am
definitively aware of the issue and I will try to debug it asap, but I
don't have the time to do that now...
Hey, I understand that of course. Two remarks however:
* I think most people could live with a message on the list and tips
to temporarily/locally fix the issues. I tend to think committed
workarounds get forgotten about...
* Even with a workaround, it's always interesting to know about
issues, even if they're not directly related to magnolia, and that
will benefit everyone, so I'd love if we could openly discuss these
things here, or point interested people to an external list/jira
issue, for instance.
That said, I just want to say again that I don't want to sound harsh
or condescending. I'm trying to keep our releases safe, and to
augment participation/involvement here. I believe discussing or
mentioning issues before fixing them, even-though time consuming, can
only improve said fixes and general awareness of issues.
Cheers,
greg
----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/magnolia/developer.html
----------------------------------------------------------------
