On Nov 1, 2007, at 13:33 , [EMAIL PROTECTED] wrote:
http://svn.magnolia.info/view?rev=12148&view=rev
Aaaaaand, the usual Greg's post commit annoying email ;)
I just have one question, about the change in ContentTypeFilter[1].
Why do we resetAggregationState there? Isn't the ContextFilter used
just before ? It seems odd and out-of-place to do this in the filter
responsible for selecting/setting the content type. Thoughts?
As a side note, please avoid committing code-style changes along with
other changes, it makes the commits very difficult to read. (I don't
mind if you use a different style, and if you feel like restyling
some classes, go ahead, but please do it in a different commit.
Eventually, we'll have to sort this issue out and find a way to keep
a consistent style, but that's not an emergency in my planning)
Cheers - and thanks for all the work !!
greg
[1] http://svn.magnolia.info/view/magnolia/trunk/magnolia-core/src/
main/java/info/magnolia/cms/filters/ContentTypeFilter.java?
rev=12148&view=diff&r1=12148&r2=12147&p1=magnolia/trunk/magnolia-core/
src/main/java/info/magnolia/cms/filters/ContentTypeFilter.java&p2=/
magnolia/trunk/magnolia-core/src/main/java/info/magnolia/cms/filters/
ContentTypeFilter.java
----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/docs/en/editor/stayupdated.html
----------------------------------------------------------------
