On 11/1/07, Grégory Joseph <[email protected]> wrote:
> I just have one question, about the change in ContentTypeFilter[1].
> Why do we resetAggregationState there? Isn't the ContextFilter used
> just before ? It seems odd and out-of-place to do this in the filter
> responsible for selecting/setting the content type. Thoughts?
Well, actually that filter was already responsible for creating the
AggregationState instance (the line above my change), and the reset is
needed just before that. (I know, looks odd to me too that
ContentFilter is used for instantiating the AggregationState, but
that's we have now...)
> As a side note, please avoid committing code-style changes along with
> other changes, it makes the commits very difficult to read. (I don't
Yes, I always try to avoid reformatting as you can see in other
commits, but when I change different parts of a class I often end up
with an automatic CTRL SHIT F...
The formatting of the code in svn now looks pretty different from the
standard we tried to follow time ago (maybe you should adjust the idea
configuration in order to be more similar to the eclipse one... I did
the idea config file time ago but you know I'm an eclipse user ;) )
This is really annoying for me, I always try to work in a way that
everything must always be automatically formatted before a commit,
that's the only way to keep consistency but the current code gets
totally reformatted also if I use the configuration that should be the
standard for the project.
I am pretty tempted to select the whole workspace and do a formatting
for everything... do you mind if I do that? :)
fabrizio
----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/docs/en/editor/stayupdated.html
----------------------------------------------------------------
