On 2012-11-13 3:30 PM, Justin Dolske wrote:
On 11/13/12 10:27 AM, Ehsan Akhgari wrote:
Agreed. Actually, reading the bug closely, there's nothing which says
someone has tried to debug this (it's not even clear if it's
reproducible locally), and it seems like the only evidence that we have
about this being PGO related is that it happens on PGO builds, which is
not enough evidence at all! So disabling PGO because of this bug is a
mistake, unless *at least* someone shows how gcc is miscompiling the
code here.
Well, but aren't you proposing doing more of exactly the problem that
led to this proposal?
David wrote about there being a pattern of bugs that only manifest on
Linux PGO, and that there's a very high cost of having someone figure
out how to reproduce and debug the issue. (Often, apparently, only to
find that the cause is a gcc PGO bug.)
It's quite possible 799295 is a real bug unrelated to PGO, but I take
the proposal as implying that we're more likely to have time to properly
investigate Linux bugs when the noise of caused-by-buggy-PGO issues is
taken out of the mix.
But the point here is that unless we know for sure that we're dealing
with a compiler bug, disabling Linux PGO builds may just wallpaper over
the problem.
Ehsan
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
