-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 02/23/2014 11:54 PM, Daniel Holbert wrote: > On 02/22/2014 12:26 PM, Hubert Figuière wrote: > > FWIW, I (and others) have been working on that, as a side project, > for a while now, and I think we're actually in pretty good shape > right now. > > We currently have only 100-200 build warnings[1], if you filter > out warnings from third-party libraries that we import (e.g. cairo, > skia, protobuf, ICU, various media codecs). > > We also have ~260 directories (and growing) that are annotated as > FAIL_ON_WARNINGS, meaning they're warning-free and they'll stay > that way (enforced by TBPL). > > If you're noticing any particularly warning-spammy code, please > file bugs (and label the directory as FAIL_ON_WARNINGs when they're > fixed). That's what I do, and it's been working.
Does that mean a patch to squelch the uninitialized variable warnings in layout will now be accepted? Those are the only warnings in layout on my (Linux, debug) builds. > layout/base/FrameLayerBuilder.cpp:3462:56 [-Wmaybe-uninitialized] > ?last? may be used uninitialized in this function > layout/base/RestyleManager.cpp:2543:41 [-Wmaybe-uninitialized] > ?lastContinuation? may be used uninitialized in this function > layout/base/nsCSSRendering.cpp:297:40 [-Wmaybe-uninitialized] > ?position? may be used uninitialized in this function > layout/base/nsCSSRendering.cpp:632:34 [-Wmaybe-uninitialized] > ?width? may be used uninitialized in this function > layout/base/nsCSSRendering.cpp:2521:27 [-Wmaybe-uninitialized] > ?isSolidBorder? may be used uninitialized in this function > layout/base/nsCSSRendering.cpp:2525:35 [-Wmaybe-uninitialized] > ?currentBackgroundClip? may be used uninitialized in this function > layout/base/nsCSSRenderingBorders.cpp:662:105 > [-Wmaybe-uninitialized] ?borderRenderColor? may be used > uninitialized in this function > layout/base/nsDisplayList.cpp:1745:28 [-Wmaybe-uninitialized] > ?color? may be used uninitialized in this function > layout/base/nsLayoutUtils.cpp:3370:11 [-Wmaybe-uninitialized] > ?result? may be used uninitialized in this function > layout/base/nsStyleSheetService.cpp:242:51 [-Wmaybe-uninitialized] > ?message? may be used uninitialized in this function > layout/generic/MathMLTextRunFactory.cpp:666:10 > [-Wmaybe-uninitialized] ?mathVar? may be used uninitialized in this > function layout/generic/nsBlockFrame.cpp:4866:72 > [-Wmaybe-uninitialized] ?overflowLines? may be used uninitialized > in this function layout/generic/nsFrame.cpp:6084:54 > [-Wmaybe-uninitialized] > ?blockFrameOrBR.nsContentAndOffset::mOffset? may be used > uninitialized in this function layout/generic/nsFrame.cpp:6597:42 > [-Wmaybe-uninitialized] ?thisBlock? may be used uninitialized in > this function layout/generic/nsFrame.cpp:7025:38 > [-Wmaybe-uninitialized] ?width? may be used uninitialized in this > function layout/generic/nsHTMLReflowState.cpp:1980:37 > [-Wmaybe-uninitialized] ?fType? may be used uninitialized in this > function layout/generic/nsSelection.cpp:5713:34 > [-Wmaybe-uninitialized] ?keycode? may be used uninitialized in this > function layout/generic/nsSelection.cpp:5723:67 > [-Wmaybe-uninitialized] ?amount? may be used uninitialized in this > function layout/generic/nsTextRunTransformations.cpp:620:54 > [-Wmaybe-uninitialized] ?child? may be used uninitialized in this > function layout/style/nsCSSParser.cpp:2823:11 > [-Wmaybe-uninitialized] ?rv? may be used uninitialized in this > function layout/style/nsCSSParser.cpp:5969:43 > [-Wmaybe-uninitialized] ?units? may be used uninitialized in this > function layout/style/nsCSSParser.cpp:9658:14 > [-Wmaybe-uninitialized] ?useCommas? may be used uninitialized in > this function layout/style/nsCSSRuleProcessor.cpp:2619:52 > [-Wmaybe-uninitialized] ?selectorForPseudo? may be used > uninitialized in this function > layout/style/nsCSSStyleSheet.cpp:286:21 [-Wmaybe-uninitialized] > ?cmp? may be used uninitialized in this function > layout/style/nsComputedDOMStyle.cpp:2542:26 [-Wmaybe-uninitialized] > ?width? may be used uninitialized in this function > layout/style/nsComputedDOMStyle.cpp:4269:29 [-Wmaybe-uninitialized] > ?color? may be used uninitialized in this function > layout/style/nsRuleNode.cpp:2864:55 [-Wmaybe-uninitialized] > ?column? may be used uninitialized in this function > layout/style/nsRuleNode.cpp:8627:63 [-Wmaybe-uninitialized] > ?borderOffset? may be used uninitialized in this function > layout/style/nsRuleNode.cpp:8631:65 [-Wmaybe-uninitialized] > ?paddingOffset? may be used uninitialized in this function > layout/style/nsRuleNode.cpp:8635:65 [-Wmaybe-uninitialized] > ?textShadowOffset? may be used uninitialized in this function > layout/style/nsStyleContext.cpp:585:22 [-Wmaybe-uninitialized] > ?otherColor? may be used uninitialized in this function > layout/tables/nsTableOuterFrame.cpp:1054:58 [-Wmaybe-uninitialized] > ?captionFirstReflow? may be used uninitialized in this function > layout/xul/nsSprocketLayout.cpp:967:25 [-Wmaybe-uninitialized] > ?maxAscent? may be used uninitialized in this function > layout/xul/nsSprocketLayout.cpp:973:22 [-Wmaybe-uninitialized] ?y? > may be used uninitialized in this function > layout/xul/nsSprocketLayout.cpp:989:45 [-Wmaybe-uninitialized] > ?isLTR? may be used uninitialized in this function > layout/xul/nsSprocketLayout.cpp:993:22 [-Wmaybe-uninitialized] ?x? > may be used uninitialized in this function > layout/xul/nsTextBoxFrame.cpp:490:78 [-Wmaybe-uninitialized] > ?underStyle? may be used uninitialized in this function > layout/xul/nsTextBoxFrame.cpp:490:79 [-Wmaybe-uninitialized] > ?underColor? may be used uninitialized in this function > layout/xul/nsTextBoxFrame.cpp:497:76 [-Wmaybe-uninitialized] > ?overStyle? may be used uninitialized in this function > layout/xul/nsTextBoxFrame.cpp:497:77 [-Wmaybe-uninitialized] > ?overColor? may be used uninitialized in this function > layout/xul/nsTextBoxFrame.cpp:578:36 [-Wmaybe-uninitialized] > ?strikeStyle? may be used uninitialized in this function > layout/xul/nsTextBoxFrame.cpp:578:37 [-Wmaybe-uninitialized] > ?strikeColor? may be used uninitialized in this function > layout/xul/tree/nsTreeBodyFrame.cpp:3216:40 [-Wmaybe-uninitialized] > ?color? may be used uninitialized in this function > layout/xul/tree/nsTreeBoxObject.cpp:86:13 [-Wmaybe-uninitialized] > ?frame? may be used uninitialized in this function zw -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iQIcBAEBCAAGBQJTD4MtAAoJEJH8wytnaapkZPQP/jUQf7KonDnhHjsIb8F6nygo 88AOu8XNdKPfOdr+aN5nkYE+0LDO6A4jC9r36YzBLqU36ghB/yYirEkbS9GyPBwy vjcE6jXeHMTWcEPSHVIzD/kQa4rbD6DHm/U47IXusv6ID4a4G3dcT5FGJeCYUDOS /e3nhs0JEuwqzMuNA53R4B65oTNYYoZ1ZlREVVyXSSqB7rpm8HbyXOka5IkjXsI5 9R+KfPxL2L1aG6ekOy+kFfRisNNH5LuI9yiXQsWhoZadJm2Sspr/reUlPanGLQnr NrLHkWINZLVPFzJgZ3cnF6cCIonPXGhqVzKPS07HjHVllXdCVeon9YHkmqbLgUHG Qjn/YaUN3V2mb5GaLDKTMZ8TDB8Pqyrwrot27aG8Bsi4lHUTanWzbfp/erljU7fb l05aB2jIGo7nv+0i58As+nAQMOx764V5eLYJGhjWeNvTRfbXF2OxobaeUmU9F19e wevax4FbOkMVxI8/FCAzAr94H789FzyRWOYh0MLT+CM4suiHOr34djPDjf6Xg86G Ohd+n3WDZfatm3Rf/YirJSZwBkPEUlPytlyjL6t/GZ1apELS9LICTBer2Qq41Sj+ zmecHYfXKPYYIrz2LMmpx5cXKBYHwnBArjKKYP9RLJvPoVFg35wSSF/owgx35HZp HUjwAy0asq7wES111Ayy =bxVZ -----END PGP SIGNATURE----- _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
