On 7/8/2015 3:08, Gregory Szorc wrote:
On Tue, Jul 7, 2015 at 5:13 PM, Jeff Gilbert <jgilb...@mozilla.com> wrote:
On Tue, Jul 7, 2015 at 3:59 PM, Eric Rahm <er...@mozilla.com> wrote:
I'm not a huge fan of the 'aFoo' style, but I am a huge fan of
consistency. So if we want to change the style guide we should update our
codebase, and I don't think we can reasonably do that automatically
without
introducing shadowing issues.
MSVC 2013 (which I believe is our main windows compiler right now) will
error during compilation if such a shadowing issue arises. Thus, if the
code compiles there, `aFoo`->`foo` is safe. I would be very surprised if
GCC or Clang didn't have an equivalent option.
Additionally I don't spend 50% of my time reviewing, so I'd say my
opinion
here (meh to aFoo) is less important. It's not an undue burden for me to
include an aPrefix and if we have static analysis to check for it that
would make it even less of an issue.
It can be a burden on the hundreds of devs who have to read and understand
the code in order to write more code. With the exception of a couple
people, review is not the bottleneck. The opinions of a few over-harried
reviewers should not hold undue sway over the many many devs writing code.
I somewhat disagree. There will always be fewer code reviewers than
contributors. And, code reviewers tend to be more senior people. The time
of a code reviewer thus tends to be more valuable than the time of the
average code author. Coupled with the fact that code review is a barrier to
landing, this translates to an incentive to make the lives and workflows of
code reviewers as frictionless as possible.
I feel strongly that the bandwidth limitations of code reviewers does
dictate to some extent how code is written. For example, I feel that
authors should spend extra effort to write detailed commit messages and
split work into multiple, easier-to-review commits, as these can
drastically reduce the time it takes for review. How much this reasoning
extends to style and things like aFoo, I'm not sure. But if I hear a
frequent code reviewer say "X makes review easier," I tend to take that
opinion more seriously than that of a non-reviewer.
+1
Few more cents: A year ago I was not using "a" in my code. Then I start
using it. And I got used to it! And - when used consistently - find it
useful from time to time to quickly get the "this is an arg" variable
info, both as a reviewer and a coder.
So, year ago I would probably be on the "get rid of it" side. Now I'm
definitely on the "use it everywhere" side.
Cheers
-hb-
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
