On Thu, Jan 28, 2016 at 8:25 AM, Honza Bambas <hbam...@mozilla.com> wrote:

> On 1/28/2016 6:30, Karl Tomlinson wrote:
>
>> Honza Bambas writes:
>>
>> On 1/25/2016 20:23, Steve Fink wrote:
>>>
>>>> For navigation, there's a list of changed files at the top
>>>> (below the fixed summary pane) that jumps to per-file anchors.
>>>>
>>> Not good enough for review process.
>>>
>>> Are you saying you want tabs or something for this (like
>>>> splinter uses)? I'd certainly like something less sluggish, but
>>>> maybe that's just my browser again.
>>>>
>>> Yes please.  Having one file on the screen at a time is very
>>> useful.
>>>
>> The next/previous file/comment keyboard shortcuts may be useful in
>> the meantime.
>>
>
> Unfortunately not.  The intention is that when I scroll down the screen
> I'm at the end of *a single file*, and of course up the screen means to be
> up at that same file.  Shortcuts are definitely unhelpful for me.  With how
> revboard works now it's just a mess of all  put together.
>

I agree with this. As I've mentioned before, NSS uses Rietveld, which
file-by-file, and I find
this much more convenient.

-Ekr


> Thanks anyway!
>
> -hb-
>
>
>
>>
>> https://www.reviewboard.org/docs/manual/2.5/users/reviews/reviewing-diffs/#keyboard-shortcuts
>> _______________________________________________
>> dev-platform mailing list
>> dev-platform@lists.mozilla.org
>> https://lists.mozilla.org/listinfo/dev-platform
>>
>>
> _______________________________________________
> dev-platform mailing list
> dev-platform@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
>
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to