Added Raine Mäkeläinen, who has been committing to qtmozembed lately, to CC.
On Thu, Apr 14, 2016 at 1:51 AM, Jim Blandy <[email protected]> wrote: > On Tue, Apr 12, 2016 at 4:27 AM, Henri Sivonen <[email protected]> wrote: >> >> On Tue, Apr 12, 2016 at 7:45 AM, Masayuki Nakano <[email protected]> >> wrote: >> > So, my question is, why do we still have Qt widget in mozilla-central? >> > What >> > the reason of keeping it in mozilla-central? >> >> My understanding is that >> https://git.merproject.org/mer-core/qtmozembed/ still uses it. As we >> are figuring out how to be more embeddable (see >> https://medium.com/@david_bryant/embed-everything-9aeff6911da0 ), it's >> probably a bad time to make life hard for an existing embedding >> solution. > > > This doesn't really answer the question. We can't have code in tree that > isn't tested, and isn't used, and has nobody responsible for it. > > If someone is willing to fix it up and get it tested and included in the > continuous integration process, then that's fine. But "someone might want to > use it in the future" can't possibly be a legit reason to keep substantial > bits of code in the tree. It looked to me like the code is being used *now*. Raine, does qtmozembed use the Qt widget code from mozilla-central? -- Henri Sivonen [email protected] https://hsivonen.fi/ _______________________________________________ dev-platform mailing list [email protected] https://lists.mozilla.org/listinfo/dev-platform
