On Tue, May 31, 2016 at 6:18 AM, Gabriele Svelto <gsve...@mozilla.com> wrote: > On 31/05/2016 13:26, Gijs Kruitbosch wrote: >> We could do a find/replace of no-arg calls to a new macro that uses >> MOZ_CRASH with a boilerplate message, and make the argument non-optional >> for new uses of MOZ_CRASH? That would avoid the problem for new >> MOZ_CRASH() additions, which seems like it would be wise so the problem >> doesn't get worse? Or is it not worth even that? > > What about adding file/line number information? This way one could > always tell where it's coming from even if it doesn't have a descriptive > string.
Agreed! These queries are much more useful if they have file names. Line numbers are a plus, but I agree that since these drift, they are not useful for collating. File names will generally not drift, and would make these queries much easier to grep for problems originating from code we're responsible for. _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
