Hi, I'd like to ask a couple of clarifications about process here:
* Is clang-format invoked automatically as part of a pre-commit hook, or something like that? * If not, should we be invoking it manually before submitting a patch? * If we submit a patch without having invoked it, will violations be caught in automation? Will they trigger a backout? Thanks, Botond On Thu, Nov 22, 2018 at 12:36 PM Felipe G <fel...@gmail.com> wrote: > > On Thu, Nov 22, 2018 at 3:07 PM Ehsan Akhgari <ehsan.akhg...@gmail.com> > wrote: > > > Felipe, gps and I talked a bit about adding a similar > > .hg-blame-ignore-revs file in the tree which can contain Mercurial sha1 > > changeset IDs for the rewrite commits to be skipped over, and people would > > be able to use the file through an alias that can be configured in ~/.hgrc > > (possible to set it up via ./mach bootstrap). Not sure if Felipe's > > investigations have lead to results yet. > > > > Indeed they have. I'm working on this in two separate bugs: > > https://bugzilla.mozilla.org/show_bug.cgi?id=1508002 is implementing the > same functionality in mercurial from`git hyper-blame`, and > https://bugzilla.mozilla.org/show_bug.cgi?id=1508324 will be used to > generate the list of past changesets > > Hope to have these wrapped up soon, and I'll write about them once they're > done. One thing to mention in advance is that gps asked to not use the word > "blame" as the Mercurial project doesn't like the negative connotations > that it brings, so I'm leaning towards `hg smart-annotate` and "# > ignore-changeset" for the string to be included in the commit message. Let > me know if anyone has thoughts about these (or leave comments in the bug) > > Felipe > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
