On 7/7/20 4:11 PM, Tom Ritter wrote:
Hey Geoff - what sorts of things would be appropriate to file there?
Or perhaps as a more basic question - what *is* comm-central? Is it
'mozilla-central with constantly-rebased Thunderbird patches on top?'
Is it an old fork of mozilla-central where a lot (or very few) patches
are copied across? Some hybrid? I like Thunderbird, and I'd like to
make things easier on you, but truthfully I know very little about how
Thunderbird is made relative to my work on Firefox (and I couldn't
find a document online).
comm-central is a separate repo from mozilla-central. You need both
comm-central and mozilla-central to build thunderbird, and comm-central
depends on stuff (headers / interfaces / etc) from mozilla-central.
A common case of mozilla-central changes breaking comm-central is stuff
like removing interfaces. There may be some interfaces that
mozilla-central has no uses of, but comm-central still uses. Removing
that kind of stuff without checking comm-central (which is pretty easy
with searchfox) and without pinging the Thunderbird folks causes
unnecessary churn for them.
Usually removing the remaining usages from comm-central is easy and
folks like Geoff or others act pretty fast on that stuff (thank you!).
Otherwise you may need to keep some of the code in mozilla-central or
what not.
-- Emilio
-tom
On Tue, Jul 7, 2020 at 3:45 AM Geoff Lankow <ge...@thunderbird.net> wrote:
Hi everybody
Many changes to mozilla-central code require complementary changes to
comm-central code. Communication about this hasn't always been
effective, which leads to breakages that could have been prevented, and
wasted developer time.
We now have a dedicated Bugzilla component for alerting Thunderbird's
developers about such things: Thunderbird - Upstream Synchronization.
Please use it to keep us informed of impending changes that we'll need
to deal with.
Thank you to those who do keep us informed. I hope having a dedicated
component makes your life easier as well as ours.
GL
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
