Hi Chris, I am not 100% sure if that's feasible with a near-zero rate of false positives, but it definitely seems worth trying out. I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1682477 to address this.
Simon On Mon, Dec 14, 2020 at 8:00 PM Chris Peterson <cpeter...@mozilla.com> wrote: > On 12/14/2020 3:23 AM, Simon Giesecke wrote: > > I was using some tools to support this, notably ClangBuildAnalyzer [2] > and > > include-what-you-use [3]. ClangBuildAnalyzer helped to detect headers > that > > are expensive to parse throughout the build, and direct efforts to reduce > > those specifically. But there remains a long tail of similar things that > > can and should be fixed. include-what-you-use helps to identify the > headers > > from which a file uses declarations to avoid depending on indirectly > > included files which might disappear from the include chain by unrelated > > changes. These tools are not readymade for everyday use, but I will try > to > > provide some ideas for using them effectively later on. > > Can include-what-you-use be configured as a Phabricator linter to warn > about new unused header includes before they are checked in? > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
