On Monday 25 January 2010 06:42:18 Brian William Hackett wrote:
> A few comments:
> 
> 1. It looks like there is a config.h.in missing from the patch.
This is generated by "autoheader" (which is run from the "autogen.sh" script) 
from information in configure.ac. I can probably turn that off, since all it 
does is provide some definitions along the lines of

/* Define to the address where bug reports for this package should be sent. */
#undef PACKAGE_BUGREPORT

which the configure script turns into something like:

/* Define to the address where bug reports for this package should be sent. */
#define PACKAGE_BUGREPORT "bhackett at stanford.edu"

(and equivalents for versions, short names and so on) although I thought that 
might be useful when building more command line tools, since you only have the 
information in one place.


> 2. Can this be made to work even if CVC3 does not use pkgconfig?
Yes.

> 3. I'm not sure pkgconfig is really needed for CVC3; I'd thought of
>  configuration for this project as being:
> 
> ./configure [--with-cvc3=/path/to/cvc3] [--with-yices=/path/to/yices]
I think we should be able to fall back to manually specifying the include and 
library paths, but I'd prefer to be able to autodetect them if possible. So if 
you have CVC3 headers and libraries in one of the standard places (e.g. 
/usr/include or /usr/local/include for headers; and /usr/lib, /usr/lib64, 
/usr/local/lib or /usr/local/lib64), then you shouldn't need to specify the 
path, but you can manually specify them if necessary (e.g. it finds the wrong 
version, or the path is completely non-standard).

I'm not so sure about yices (since I'm really only interested in the gcc front 
end, and I haven't sorted out the combined licensing bits in my head, I 
haven't actually agreed to the yices license yet), but manually specifying the 
path could be a good option. We should be able to automatically detect yices 
if it is unpacked into the sixgill source directory.

A couple of questions:
1. Do you know if a particular version of CVC3 is required (e.g. needs to be 
2.1 or later) ?
2. If yices is unpacked into the sixgill source dir, what does the top level 
directory structure look like. Is it something like:
sixgill/
sixgill/yices
sixgill/yices/include/
sixgill/yices/lib/

Let me have another go with the configure stuff, and I'll send you a revised 
patch.

[I'll have a look at the usage instructions, give it a try, and follow-up on 
that part separately]

Brad
_______________________________________________
dev-static-analysis mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-static-analysis

Reply via email to