Ehsan Akhgari <[email protected]> writes: > On 2013-01-23 10:36 AM, Chris Cleeland wrote:
[...] >> Yes, it's the query. I've got some hacks that sort of work, but not 100%. >> Ultimately I think some of the stuff in query.py will have to change, too, >> but I'm not fully cognizant of what dragons might be there so I'm reluctant >> to suggest a change specifically for turning back in. What I'm trying to >> do is document the SQL queries that generate the correct data so that >> hopefully a person who understands the dragons can guide me on refactoring >> query.py content or even just do it since my python is, uh, not very good. > > Perhaps you can share your work on your fork and see if Erik can help > finish it up? Yes, I'd have thought some more clarifying comments wouldn't hurt. I think one comment in the issue mentions problems of a very slow query. I suspect it would be OK just to get rid of the indirect parts of the query (or move them to a separate menu item, if that's feasible). I think it's nice to be able to find indirect callers and callees, but I must admit I was expecting just to get direct results. Possibly as a temporary measure, I think I'll try commenting out the indirect parts of the queries and see how that feels in use. _______________________________________________ dev-static-analysis mailing list [email protected] https://lists.mozilla.org/listinfo/dev-static-analysis
