When we met in Taipei we had some discussion about how there were some code that was unnecessarily confusing due to poor names. I collected the following list of renames then (and since) that I'd like us to make. The list I've collected so far is below? Thoughts? Additions? Opinions on the options below for block-in-inline splits?
-David nsHTMLReflowState -> mozilla::ReflowInput nsHTMLReflowMetrics -> mozilla::ReflowOutput nsHTMLReflowState::availableHeight -> nsHTMLReflowState::distanceToBreak NS_FRAME_IS_SPECIAL -> NS_FRAME_BLOCK_IN_INLINE_SPLIT or NS_FRAME_IB_SPLIT IsFrameSpecial -> IsFramePartOfBlockInInlineSplit or ...IBSplit etc. (opinions on whether the shorter or longer names are better?) nsHTMLCSSStyleSheet -> mozilla::StyleAttributeRuleProcessor nsHTMLStyleSheet -> mozilla::PresentationAttributeRuleProcessor (the first step here was https://bugzilla.mozilla.org/show_bug.cgi?id=882573) (Although I also wonder if we should rename RuleProcessor to something like RuleSource or RuleProvider.) nsGfxScrollFrameInner -> mozilla::GfxScrollFrameHelper (This is confusing because there is an inner frame too!) removing mozilla::css namespace and just having the things in it be in mozilla, in some cases with class names beginning with CSS. -- 𝄞 L. David Baron http://dbaron.org/ 𝄂 𝄢 Mozilla http://www.mozilla.org/ 𝄂 _______________________________________________ dev-tech-layout mailing list [email protected] https://lists.mozilla.org/listinfo/dev-tech-layout
