There are a number of XUL Box layout methods that were moved to nsIFrame. In a previous discussion about names, we came to the conclusion that renaming these to have "XUL" in the name would reduce confusion, especially in cases where there is an analogous non-XUL method also on nsIFrame.
So I propose renaming the following methods:
bool IsBoxFrame() const
bool IsBoxWrapped() const
nsSize GetMinSize(nsBoxLayoutState& aBoxLayoutState)
nsSize GetPrefSize(nsBoxLayoutState& aBoxLayoutState)
nsSize GetMaxSize(nsBoxLayoutState& aBoxLayoutState)
nsSize GetMinSizeForScrollArea(nsBoxLayoutState& aBoxLayoutState)
uint32_t GetOrdinal()
nscoord GetFlex(nsBoxLayoutState& aBoxLayoutState)
nscoord GetBoxAscent(nsBoxLayoutState& aBoxLayoutState)
bool IsCollapsed()
void SetBounds(nsBoxLayoutState& aBoxLayoutState, const nsRect& aRect,
bool aRemoveOverflowAreas = false)
nsresult Layout(nsBoxLayoutState& aBoxLayoutState)
nsIFrame* GetChildBox() const
nsIFrame* GetNextBox() const
nsIFrame* GetParentBox() const
nsresult GetBorderAndPadding(nsMargin& aBorderAndPadding)
nsresult GetBorder(nsMargin& aBorder)
nsresult GetPadding(nsMargin& aBorderAndPadding)
nsresult GetMargin(nsMargin& aMargin)
void SetLayoutManager(nsBoxLayout* aLayout)
nsBoxLayout* GetLayoutManager()
void SetLayoutManager(nsBoxLayout* aLayout)
nsBoxLayout* GetLayoutManager()
nsresult GetClientRect(nsRect& aContentRect)
Valignment GetVAlign() const
Halignment GetHAlign() const
bool IsHorizontal() const
bool IsNormalDirection() const
nsresult Redraw(nsBoxLayoutState& aState)
nsresult RelayoutChildAtOrdinal(nsBoxLayoutState& aState, nsIFrame* aChild)
bool GetMouseThrough() const
#ifdef DEBUG_LAYOUT
nsresult SetDebug(nsBoxLayoutState& aState, bool aDebug)
nsresult GetDebug(bool& aDebug)
nsresult DumpBox(FILE* out)
#endif
by inserting the word XUL in the following ways:
IsXULBoxFrame
IsXULBoxWrapped
GetXULMinSize
GetXULPrefSize
GetXULMaxSize
GetXULMinSizeForScrollArea
GetXULOrdinal
GetXULFlex
GetXULBoxAscent
XULIsCollapsed
XULSetBounds
XULLayout
GetChildXULBox
GetNextXULBox
GetParentXULBox
GetXULBorderAndPadding
GetXULBorder
GetXULPadding
GetXULMargin
SetXULLayoutManager
GetXULLayoutManager
SetXULLayoutManager
GetXULLayoutManager
GetXULClientRect
GetXULVAlign
GetXULHAlign
IsXULHorizontal
IsXULNormalDirection
XULRedraw
XULRelayoutChildAtOrdinal
GetXULMouseThrough
#ifdef DEBUG_LAYOUT
SetXULDebug
GetXULDebug
XULDumpBox
#endif
Does this seem reasonable?
-David
--
𝄞 L. David Baron http://dbaron.org/ 𝄂
𝄢 Mozilla https://www.mozilla.org/ 𝄂
Before I built a wall I'd ask to know
What I was walling in or walling out,
And to whom I was like to give offense.
- Robert Frost, Mending Wall (1914)
signature.asc
Description: Digital signature
_______________________________________________ dev-tech-layout mailing list [email protected] https://lists.mozilla.org/listinfo/dev-tech-layout
