On Wednesday 2014-02-05 09:32 +1100, Cameron McCormack wrote: > L. David Baron wrote: > >There are a number of XUL Box layout methods that were moved to > >nsIFrame. In a previous discussion about names, we came to the > >conclusion that renaming these to have "XUL" in the name would > >reduce confusion, especially in cases where there is an analogous > >non-XUL method also on nsIFrame. > > > >So I propose renaming the following methods: > > Making it obvious they're XUL layout things makes sense to me. > Although why XULIsCollapsed but IsXULHorizontal?
Yeah, should probably be IsXULCollapsed. > Also is it possible to push any of these methods down to nsBox/nsBoxFrame? Maybe, but I suspect not easily (at least for many of them). It's certainly a lot easier to rename them. -David -- 𝄞 L. David Baron http://dbaron.org/ 𝄂 𝄢 Mozilla https://www.mozilla.org/ 𝄂 Before I built a wall I'd ask to know What I was walling in or walling out, And to whom I was like to give offense. - Robert Frost, Mending Wall (1914)
signature.asc
Description: Digital signature
_______________________________________________ dev-tech-layout mailing list [email protected] https://lists.mozilla.org/listinfo/dev-tech-layout
