Done.
On Wed, Mar 6, 2013 at 5:57 PM, Christopher <[email protected]> wrote: > +1 for this formatter change also. > > -- > Christopher L Tubbs II > http://gravatar.com/ctubbsii > > > On Wed, Mar 6, 2013 at 4:53 PM, Billie Rinaldi <[email protected]> > wrote: >> Do Java -> Code Style -> Formatter -> Edit (assuming you have the Accumulo >> formatter) -> Indentation, and the last checkbox is "Empty lines". Uncheck >> that checkbox, Apply/OK, Apply, then export the formatter and replace >> trunk/contrib/Eclipse-Accumulo-Codestyle.xml. >> >> Or it would probably also work to change the following line to false in the >> Codestyle and re-import it. >> <setting id="org.eclipse.jdt.core.formatter.indent_empty_lines" >> value="true"/> >> >> Billie >> >> >> On Wed, Mar 6, 2013 at 1:29 PM, David Medinets >> <[email protected]>wrote: >> >>> Chris, you seem to be correct. In fact, the Eclipse formatter actually >>> adds whitespace on blank lines. >>> >>> public static HdfsFileSystemConfigBuilder getInstance() { >>> return BUILDER; >>> } >>> <space><space> >>> /** >>> */ >>> >>> I removed the spaces show above. Then ran Source > Format. The spaces >>> were inserted for me. >>> >>> I don't know how to make Eclipse stop adding the spaces. I tried >>> turning on the 'Remove trailing whitespace on all lines' option in >>> Java > Editor > Save Actions but that did not help. >>> >>> Any ideas? >>> >>> On Wed, Mar 6, 2013 at 2:57 PM, Christopher <[email protected]> wrote: >>> > Wouldn't that rule conflict with our formatter? I'm pretty sure our >>> > formatter allows "blank" lines to be indented with spaces. >>> > >>> > -- >>> > Christopher L Tubbs II >>> > http://gravatar.com/ctubbsii >>> > >>> > >>> > On Wed, Mar 6, 2013 at 10:23 AM, David Medinets >>> > <[email protected]> wrote: >>> >> I have a free day due to snowfall and while this is a fairly silly >>> >> rule, writing a short script to rule all the java files through sed >>> >> should be fairly painless. As part of this change, I will commit a >>> >> one-rule checkstyle.xml file which just runs this 'no spaces at end of >>> >> line' rule. Over time, more rules can be added to that align with the >>> >> Accumulo community's style guidelines. >>> >> >>> >> Any objection? >>>
