----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15279/#review28316 -----------------------------------------------------------
src/server/src/main/java/org/apache/accumulo/server/util/Initialize.java <https://reviews.apache.org/r/15279/#comment55124> I think this code for determining the fsUri is redundant. In main() the filesystem is obtained by calling FileUtil.getFileSystem() which uses INSTANCE_DFS_URI. Therefore maybe just call fs.getUri(). src/server/src/main/java/org/apache/accumulo/server/util/Initialize.java <https://reviews.apache.org/r/15279/#comment55125> It would also be useful to include the value of Property.INSTANCE_DFS_DIR in this error message. - kturner On Nov. 6, 2013, 8:47 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15279/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2013, 8:47 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-1556 > https://issues.apache.org/jira/browse/ACCUMULO-1556 > > > Repository: accumulo > > > Description > ------- > > The Initialize class now generates clearer error messages if an initialized > instance is discovered. The messages vary depending on whether > instance.dfs.uri is used. > > Note that to facilitate unit testing, the verification logic in > Initialize.doInit() was refactored into a checkInit() method. > > > Diffs > ----- > > pom.xml 9ed2fdf1c7a1f8831667b27bfaa307fbe2467fe8 > src/server/pom.xml 6421bc69cda5116f9716d30adc3d510baa3bb7d6 > src/server/src/main/java/org/apache/accumulo/server/util/Initialize.java > 51576fcc8ff8ffcd65a78bfeaaaf51036360a6bc > > src/server/src/test/java/org/apache/accumulo/server/util/InitializeTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/15279/diff/ > > > Testing > ------- > > Ran initialization with patch changes on 1.4.3 cluster under CDH 4.3. Tested > successful initialization and correct emission of error messages when > instance.dfs.uri was used and was not used. Also, implemented unit tests for > altered code. > > > Thanks, > > Bill Havanki > >
