> On Nov. 14, 2013, 10:03 p.m., Bill Havanki wrote: > > src/examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/RandomBatchWriter.java, > > line 156 > > <https://reviews.apache.org/r/15517/diff/1/?file=384504#file384504line156> > > > > I believe this will lead to an infinite loop if max - min < num. The > > loop will keep adding numbers in the range [min, max) but cannot terminate > > because the set cannot grow beyond size max - min. > > > > I think the check for this condition above should do System.exit(1).
yep! exactly why the above check was added. :/ - Sean ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15517/#review28912 ----------------------------------------------------------- On Nov. 14, 2013, 4:29 p.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15517/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2013, 4:29 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-1892 > https://issues.apache.org/jira/browse/ACCUMULO-1892 > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-1892 changes RandomBatchWriter to ensure it writes the specified > number of rowids. > > > Diffs > ----- > > > src/examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/RandomBatchWriter.java > 3206fa6bbb5e560175e9aec6a1e612185e4ca945 > > Diff: https://reviews.apache.org/r/15517/diff/ > > > Testing > ------- > > unit tests pass. simple.examples.Examples functional tests pass (given fixes > in ACCUMULO-1878 to actually run them). > > > Thanks, > > Sean Busbey > >
