----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15517/#review28978 -----------------------------------------------------------
Ship it! The changes look good. I also pulled down the patch and tried running it, works great. src/examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/RandomBatchWriter.java <https://reviews.apache.org/r/15517/#comment56032> Not sure if "atleast" is a word. I did not notice this in the code review, but when I ran the program and triggered this case it really stuck out. I can fix this after applying the patch unless you would like to fix it. - kturner On Nov. 14, 2013, 10:23 p.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15517/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2013, 10:23 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-1892 > https://issues.apache.org/jira/browse/ACCUMULO-1892 > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-1892 changes RandomBatchWriter to ensure it writes the specified > number of rowids. > > > Diffs > ----- > > > src/examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/RandomBatchWriter.java > 3206fa6bbb5e560175e9aec6a1e612185e4ca945 > > Diff: https://reviews.apache.org/r/15517/diff/ > > > Testing > ------- > > unit tests pass. simple.examples.Examples functional tests pass (given fixes > in ACCUMULO-1878 to actually run them). > > > Thanks, > > Sean Busbey > >
