-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16224/
-----------------------------------------------------------

Review request for accumulo.


Bugs: ACCUMULO-1986
    https://issues.apache.org/jira/browse/ACCUMULO-1986


Repository: accumulo


Description
-------

Integrity checks for constructing Key and Mutation objects from Thrift.

To make adding unit tests easier, I updated KeyTest and MutationTest to use 
JUnit 4 annotations. That drove the need to rename an assertEquals method in 
MutationTest, hence all the changes to "checkCU" there.

See the JIRA ticket for a list of classes that I evaluated for these same sort 
of integrity checks.


Diffs
-----

  src/core/src/main/java/org/apache/accumulo/core/data/Key.java cfb0b5c 
  src/core/src/main/java/org/apache/accumulo/core/data/Mutation.java 3979da9 
  src/core/src/test/java/org/apache/accumulo/core/data/KeyTest.java 9a7f0d7 
  src/core/src/test/java/org/apache/accumulo/core/data/MutationTest.java 
38ddcad 

Diff: https://reviews.apache.org/r/16224/diff/


Testing
-------

Unit tests and functional tests pass.


Thanks,

Bill Havanki

Reply via email to