> On Dec. 9, 2013, 12:04 p.m., Sean Busbey wrote: > > test/system/auto/run.py, line 134 > > <https://reviews.apache.org/r/15947/diff/1/?file=392813#file392813line134> > > > > nit: could you use the long form invocation that makes it clear what > > the boolean argument is for? (ignore errors?)
Ah, definitely clearer. Thanks. > On Dec. 9, 2013, 12:04 p.m., Sean Busbey wrote: > > test/system/auto/TestUtils.py, lines 275-278 > > <https://reviews.apache.org/r/15947/diff/1/?file=392812#file392812line275> > > > > Could we use a more descriptive variable than cp? recommend > > "settings_classpath" or "generated_classpath" Using settings_classpath in next diff. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15947/#review30022 ----------------------------------------------------------- On Dec. 2, 2013, 3:44 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15947/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2013, 3:44 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-1944 > https://issues.apache.org/jira/browse/ACCUMULO-1944 > > > Repository: accumulo > > > Description > ------- > > The -C flag for test/system/auto/run.py did not work. This changeset allows > it to work again if a functional Cobertura installation is placed under > $ACCUMULO_HOME/lib/test/cobertura. > > The code for producing instrumented Accumulo code was inactive and out of > date. It was reworked so that, if -C is passed, the Accumulo JARs are > instrumented and placed into a location ahead of their standard location in > the test classpath. (If -C is not passed, any instrumented JARs are removed.) > The classpath is also dynamically adjusted to include whatever Cobertura JAR > is available; its name includes a version number (as of 2.0.x). > > The command-line scripts shipped with Cobertura 2.0.x are out of date and do > not work out of the box. Pull request #102 was submitted to > cobertura/cobertura on Github to fix the problem; in lieu of that, the > scripts must be manually updated to use a correct classpath. > > > Diffs > ----- > > test/system/auto/TestUtils.py f6eca67ea7a083408532025c50a80b58e0bcc902 > test/system/auto/run.py 8e1a9bbf1396c72f5a88543315449c5d6fc1dc26 > > Diff: https://reviews.apache.org/r/15947/diff/ > > > Testing > ------- > > Ran simple and stress functional tests on 1.4.5-SNAPSHOT, both with and > without -C. Verified that coverage reports are generated. > > > Thanks, > > Bill Havanki > >
