> On Feb. 28, 2014, 2:56 p.m., kturner wrote:
> > test/system/upgrade_test.sh, line 246
> > <https://reviews.apache.org/r/18625/diff/1/?file=506994#file506994line246>
> >
> >     Would be nice to put this test in a subdir, like system/test/upgrade 
> > and under that have a file like 
> > system/test/upgrade/conf/15/accumulo_site.template.xml

+1

The subdirectory will also make it easier to do things like add a README that 
explains how to run the test.


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18625/#review35783
-----------------------------------------------------------


On Feb. 28, 2014, 2:23 p.m., John McNamee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18625/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2014, 2:23 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2145
>     https://issues.apache.org/jira/browse/ACCUMULO-2145
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> This is still a work in progress.
> 
> The framework would configure the Accumulo versions, HDFS, zookeeper, and 
> which test to run.
> Runs a set of upgrade tests. 
> 
> 
> Diffs
> -----
> 
>   test/system/upgrade_test.sh 6259e1c 
> 
> Diff: https://reviews.apache.org/r/18625/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> John McNamee
> 
>

Reply via email to