----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18625/#review35793 -----------------------------------------------------------
test/system/upgrade_test.sh <https://reviews.apache.org/r/18625/#comment66538> Is there a reason this is limited to 1.5.x to 1.6.x? i.e. are the configurable bits keeping us from testing 1.7? test/system/upgrade_test.sh <https://reviews.apache.org/r/18625/#comment66539> Can we move this into a README.md that covers the upgrade test? test/system/upgrade_test.sh <https://reviews.apache.org/r/18625/#comment66541> nit: whitespace test/system/upgrade_test.sh <https://reviews.apache.org/r/18625/#comment66542> nit: whitespace test/system/upgrade_test.sh <https://reviews.apache.org/r/18625/#comment66543> nit: whitespace test/system/upgrade_test.sh <https://reviews.apache.org/r/18625/#comment66547> Same comment as Alex had above; make the mkdir match the existence check. test/system/upgrade_test.sh <https://reviews.apache.org/r/18625/#comment66544> nit: whitespace test/system/upgrade_test.sh <https://reviews.apache.org/r/18625/#comment66546> Is there a reason this check uses CURR_LOCATION as a parent for TEMP_DIR and all the others for ZK/Hadoop don't? test/system/upgrade_test.sh <https://reviews.apache.org/r/18625/#comment66545> nit: whitespace test/system/upgrade_test.sh <https://reviews.apache.org/r/18625/#comment66548> Same comment as Alex had above; make the mkdir match the existence check. test/system/upgrade_test.sh <https://reviews.apache.org/r/18625/#comment66549> It'd be simpler to do something like if [ ! -d $TEMP_DIR/$ACCUMULO_OLD_DIR ]; then mkdir $TEMP_DIR/$ACCUMULO_OLD_DIR tar -C $TEMP_DIR/$ACCUMULO_OLD_DIR -xzf $ACCUMULO_OLD_TAR fi Is there some other goal in checking for an already expanded tarball in the working directory? test/system/upgrade_test.sh <https://reviews.apache.org/r/18625/#comment66550> Same thing as teh old accumulo tar. expanding directly into the target directory would be simpler. - Sean Busbey On Feb. 28, 2014, 2:23 p.m., John McNamee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18625/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2014, 2:23 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2145 > https://issues.apache.org/jira/browse/ACCUMULO-2145 > > > Repository: accumulo > > > Description > ------- > > This is still a work in progress. > > The framework would configure the Accumulo versions, HDFS, zookeeper, and > which test to run. > Runs a set of upgrade tests. > > > Diffs > ----- > > test/system/upgrade_test.sh 6259e1c > > Diff: https://reviews.apache.org/r/18625/diff/ > > > Testing > ------- > > > Thanks, > > John McNamee > >
