-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19592/
-----------------------------------------------------------
Review request for accumulo.
Bugs: ACCUMULO-2470
https://issues.apache.org/jira/browse/ACCUMULO-2470
Repository: accumulo
Description
-------
A variety of low-hanging fruit unit tests to increase coverage in the
server/base module to 15% and class coverage to 25%.
The most important part of this review is the set of changes to ProblemReport,
done to enable testing of it. Mostly, existing methods were augmented with new
ones that take in parameters like ZooReaderWriter and Instance objects, which
can be set or mocked at test time.
Diffs
-----
server/base/src/main/java/org/apache/accumulo/server/problems/ProblemReport.java
fec4e550a743bbf36d92688c5ddf5da561d8f715
server/base/src/test/java/org/apache/accumulo/server/AccumuloTest.java
PRE-CREATION
server/base/src/test/java/org/apache/accumulo/server/ServerOptsTest.java
PRE-CREATION
server/base/src/test/java/org/apache/accumulo/server/conf/TableConfigurationTest.java
PRE-CREATION
server/base/src/test/java/org/apache/accumulo/server/master/state/MergeInfoTest.java
PRE-CREATION
server/base/src/test/java/org/apache/accumulo/server/master/state/TabletLocationStateTest.java
PRE-CREATION
server/base/src/test/java/org/apache/accumulo/server/problems/ProblemReportTest.java
PRE-CREATION
server/base/src/test/java/org/apache/accumulo/server/problems/ProblemReportingIteratorTest.java
PRE-CREATION
server/base/src/test/java/org/apache/accumulo/server/tablets/LogicalTimeTest.java
PRE-CREATION
server/base/src/test/java/org/apache/accumulo/server/tablets/MillisTimeTest.java
PRE-CREATION
server/base/src/test/java/org/apache/accumulo/server/tablets/TabletTimeTest.java
PRE-CREATION
server/base/src/test/java/org/apache/accumulo/server/util/AdminCommandsTest.java
PRE-CREATION
server/base/src/test/java/org/apache/accumulo/server/util/FileInfoTest.java
PRE-CREATION
server/base/src/test/java/org/apache/accumulo/server/util/FileUtilTest.java
PRE-CREATION
server/base/src/test/java/org/apache/accumulo/server/util/TServerUtilsTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/19592/diff/
Testing
-------
Unit tests pass.
Thanks,
Bill Havanki
