----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19592/#review38443 -----------------------------------------------------------
server/base/src/test/java/org/apache/accumulo/server/problems/ProblemReportingIteratorTest.java <https://reviews.apache.org/r/19592/#comment70644> What's the advantage of using a mock Range here? server/base/src/test/java/org/apache/accumulo/server/tablets/TabletTimeTest.java <https://reviews.apache.org/r/19592/#comment70643> Why is this test ignored? server/base/src/test/java/org/apache/accumulo/server/util/AdminCommandsTest.java <https://reviews.apache.org/r/19592/#comment70642> Should we assert something? - Mike Drob On March 24, 2014, 8:19 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19592/ > ----------------------------------------------------------- > > (Updated March 24, 2014, 8:19 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2470 > https://issues.apache.org/jira/browse/ACCUMULO-2470 > > > Repository: accumulo > > > Description > ------- > > A variety of low-hanging fruit unit tests to increase branch coverage in the > server/base module to 15% and class coverage to 25%. > > The most important part of this review is the set of changes to > ProblemReport, done to enable testing of it. Mostly, existing methods were > augmented with new ones that take in parameters like ZooReaderWriter and > Instance objects, which can be set or mocked at test time. > > > Diffs > ----- > > > server/base/src/main/java/org/apache/accumulo/server/problems/ProblemReport.java > fec4e550a743bbf36d92688c5ddf5da561d8f715 > server/base/src/test/java/org/apache/accumulo/server/AccumuloTest.java > PRE-CREATION > server/base/src/test/java/org/apache/accumulo/server/ServerOptsTest.java > PRE-CREATION > > server/base/src/test/java/org/apache/accumulo/server/conf/TableConfigurationTest.java > PRE-CREATION > > server/base/src/test/java/org/apache/accumulo/server/master/state/MergeInfoTest.java > PRE-CREATION > > server/base/src/test/java/org/apache/accumulo/server/master/state/TabletLocationStateTest.java > PRE-CREATION > > server/base/src/test/java/org/apache/accumulo/server/problems/ProblemReportTest.java > PRE-CREATION > > server/base/src/test/java/org/apache/accumulo/server/problems/ProblemReportingIteratorTest.java > PRE-CREATION > > server/base/src/test/java/org/apache/accumulo/server/tablets/LogicalTimeTest.java > PRE-CREATION > > server/base/src/test/java/org/apache/accumulo/server/tablets/MillisTimeTest.java > PRE-CREATION > > server/base/src/test/java/org/apache/accumulo/server/tablets/TabletTimeTest.java > PRE-CREATION > > server/base/src/test/java/org/apache/accumulo/server/util/AdminCommandsTest.java > PRE-CREATION > server/base/src/test/java/org/apache/accumulo/server/util/FileInfoTest.java > PRE-CREATION > server/base/src/test/java/org/apache/accumulo/server/util/FileUtilTest.java > PRE-CREATION > > server/base/src/test/java/org/apache/accumulo/server/util/TServerUtilsTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/19592/diff/ > > > Testing > ------- > > Unit tests pass. > > > Thanks, > > Bill Havanki > >
