> On March 27, 2014, 3:02 p.m., Mike Drob wrote: > > server/gc/src/test/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogsTest.java, > > line 40 > > <https://reviews.apache.org/r/19732/diff/1/?file=538473#file538473line40> > > > > The tests in this class are hard to parse, mentally. Not sure what can > > be done about it though.
I'll see what I can do. You're right, it is hard to follow. > On March 27, 2014, 3:02 p.m., Mike Drob wrote: > > server/gc/src/test/java/org/apache/accumulo/gc/SimpleGarbageCollectorTest.java, > > line 65 > > <https://reviews.apache.org/r/19732/diff/1/?file=538475#file538475line65> > > > > Can this just be a @Before method, even though it won't be used > > everywhere? Yes, I'll do that. > On March 27, 2014, 3:02 p.m., Mike Drob wrote: > > server/gc/src/test/java/org/apache/accumulo/gc/SimpleGarbageCollectorTest.java, > > lines 87-94 > > <https://reviews.apache.org/r/19732/diff/1/?file=538475#file538475line87> > > > > Does there need to be a verify(volMgr) call? I'll add it. In general I don't add verify for a mock if the rest of the test would have failed if the mock wasn't used properly. It doesn't hurt to add it. > On March 27, 2014, 3:02 p.m., Mike Drob wrote: > > server/gc/src/test/java/org/apache/accumulo/gc/SimpleGarbageCollectorTest.java, > > line 139 > > <https://reviews.apache.org/r/19732/diff/1/?file=538475#file538475line139> > > > > Possible test case: null or "" Nice, will add. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19732/#review38785 ----------------------------------------------------------- On March 27, 2014, 12:21 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19732/ > ----------------------------------------------------------- > > (Updated March 27, 2014, 12:21 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2558 > https://issues.apache.org/jira/browse/ACCUMULO-2558 > > > Repository: accumulo > > > Description > ------- > > Code changes accompanying unit tests: > - visibility of methods under test changed from private to package > - some methods refactored to take arguments, to permit testability > - GarbageCollectWriteAheadLogs.isUUID() improved to check for null and to > check > length of potential UUID, since UUID.fromString() will accept UUIDs > with extraneous > leading zeroes in components > - SimpleGarbageCollector.getZooLock() finds ZK root using instance field > of class > instead of calling HdfsZooInstance.getInstance() again > - SimpleGarbageCollector.init() no longer declares throwing IOException > > > Diffs > ----- > > server/gc/pom.xml 22e67cd53733fbe7a91db72d2ac944fd3804c6a0 > > server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java > ab2ab42250840bb41e08f6823e4b0005ed92da14 > server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java > 89925b46a77a978982208f8117f6ec38281450e3 > > server/gc/src/test/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogsTest.java > PRE-CREATION > > server/gc/src/test/java/org/apache/accumulo/gc/SimpleGarbageCollectorOptsTest.java > PRE-CREATION > > server/gc/src/test/java/org/apache/accumulo/gc/SimpleGarbageCollectorTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/19732/diff/ > > > Testing > ------- > > Unit tests pass! > > > Thanks, > > Bill Havanki > >
