> On March 27, 2014, 2:50 p.m., Mike Drob wrote: > > server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java, > > line 232 > > <https://reviews.apache.org/r/19732/diff/1/?file=538472#file538472line232> > > > > Should probably still have a 4-arg init() that calls this one? > > Bill Havanki wrote: > I don't know, it's only called from the main method here, so I left it > out. Is it better to keep it for stability?
I'll add it back in to be safe. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19732/#review38744 ----------------------------------------------------------- On March 27, 2014, 4:56 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19732/ > ----------------------------------------------------------- > > (Updated March 27, 2014, 4:56 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2558 > https://issues.apache.org/jira/browse/ACCUMULO-2558 > > > Repository: accumulo > > > Description > ------- > > Code changes accompanying unit tests: > - visibility of methods under test changed from private to package > - some methods refactored to take arguments, to permit testability > - GarbageCollectWriteAheadLogs.isUUID() improved to check for null and to > check > length of potential UUID, since UUID.fromString() will accept UUIDs > with extraneous > leading zeroes in components > - SimpleGarbageCollector.getZooLock() finds ZK root using instance field > of class > instead of calling HdfsZooInstance.getInstance() again > - SimpleGarbageCollector.init() no longer declares throwing IOException > > > Diffs > ----- > > server/gc/pom.xml 22e67cd53733fbe7a91db72d2ac944fd3804c6a0 > > server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java > ab2ab42250840bb41e08f6823e4b0005ed92da14 > server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java > 89925b46a77a978982208f8117f6ec38281450e3 > > server/gc/src/test/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogsTest.java > PRE-CREATION > > server/gc/src/test/java/org/apache/accumulo/gc/SimpleGarbageCollectorOptsTest.java > PRE-CREATION > > server/gc/src/test/java/org/apache/accumulo/gc/SimpleGarbageCollectorTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/19732/diff/ > > > Testing > ------- > > Unit tests pass! > > > Thanks, > > Bill Havanki > >
