Github user haydenmarchant commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/9#discussion_r14173926
--- Diff: bin/bootstrap_config.sh ---
@@ -119,6 +123,86 @@ while [[ "${OVERWRITE}" = "0" ]]; do
done
echo "Coppying configuration files to: ${CONF_DIR}"
+if [[ -z "${SIZE}" ]]; then
--- End diff --
Before my change, the sets of variables describing the JVM params were
initiated before the user prompts (_1GB_master, _512MB_gc etc......). However,
the JVM settings for the 3GB tservers contains GC settings which depend on JVM
vendor. So I had to put the JVM choice before setting the 3GB model. In theory,
the JVM vendor could influence other variables of other processes in the future.
So this could be worded differently - the initiation of the process
specific JVM parameters are now being done after the user prompts, instead of
before.
Is that good enough reason to leave as is?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
