Github user haydenmarchant commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/9#discussion_r14421467
--- Diff: conf/templates/accumulo-env.sh ---
@@ -51,10 +51,11 @@ test -z "$ACCUMULO_TSERVER_OPTS" && export
ACCUMULO_TSERVER_OPTS="${POLICY} ${tS
test -z "$ACCUMULO_MASTER_OPTS" && export ACCUMULO_MASTER_OPTS="${POLICY}
${masterHigh_masterLow}"
test -z "$ACCUMULO_MONITOR_OPTS" && export
ACCUMULO_MONITOR_OPTS="${POLICY} ${monitorHigh_monitorLow}"
test -z "$ACCUMULO_GC_OPTS" && export
ACCUMULO_GC_OPTS="${gcHigh_gcLow}"
-test -z "$ACCUMULO_GENERAL_OPTS" && export
ACCUMULO_GENERAL_OPTS="-XX:+UseConcMarkSweepGC
-XX:CMSInitiatingOccupancyFraction=75 -Djava.net.preferIPv4Stack=true"
+test -z "$ACCUMULO_GENERAL_OPTS" && export
ACCUMULO_GENERAL_OPTS="${gcPolicy} -Djava.net.preferIPv4Stack=true
${jaxpDocBuilderFactory} ${randomNumGeneratorProviderOverride}"
test -z "$ACCUMULO_OTHER_OPTS" && export
ACCUMULO_OTHER_OPTS="${otherHigh_otherLow}"
# what do when the JVM runs out of heap memory
export ACCUMULO_KILL_CMD='kill -9 %p'
+export GC_POLICY_ARGS="${gcPolicy}"
--- End diff --
The intention is that this variable will be used by the MiniAccumuloCluster
class when the MiniAccumuloClusterImpl class launches the Table Server using
Java exec. At the moment, the class has hard-coded the GC params for Sun JVM.
My intention is that it will use System.getenv("GC_POLICY_ARGS").
I did not include this change yet.
If the approach that I've taken makes sense, let me know and I will
complete the change to MiniAccumuloClusterImpl
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
