> On July 10, 2014, 12:28 p.m., Mike Drob wrote: > > pom.xml, lines 817-824 > > <https://reviews.apache.org/r/23391/diff/1/?file=627668#file627668line817> > > > > Too pedantic. Do other maven properties operate on strict true/false > > values? > > Sean Busbey wrote: > what would you recommend as an alternative?
the advantage I see in this restriction is * keeps user intention clear * looks like the skip properties from e.g. findbugs * gives us a chance to give user feedback if they set something that won't cause activations (e.g. "-Drat.skip=1") - Sean ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23391/#review47561 ----------------------------------------------------------- On July 10, 2014, 8:34 a.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23391/ > ----------------------------------------------------------- > > (Updated July 10, 2014, 8:34 a.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2986 > https://issues.apache.org/jira/browse/ACCUMULO-2986 > > > Repository: accumulo > > > Description > ------- > > * puts rat plugin into profile > * activates profile by default > * ignores rat errrors by default > > > Diffs > ----- > > pom.xml 2bc87cf082dfeb7bfe1a3fac1fe4fba1eaa87edd > > Diff: https://reviews.apache.org/r/23391/diff/ > > > Testing > ------- > > verified rat warnings and failures given move from master -> 1.6.1-SNAPSHOT > branch with no definitions, -Drat.skip=true, -Drat.skip=false, > -Drat.ignoreErrors=true, and profile to check errors in ~/.m2/settings.xml > > > Thanks, > > Sean Busbey > >
