----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23391/#review47614 -----------------------------------------------------------
-1 There's absolutely no reason to create a profile and options to skip the execution of the plugin since there is a built-in mechanism for controlling the rat check's impact on the build (eg. by setting rat.ignoreErrors). This change unnecessarily complicates the pom files, with insufficient utility to justify it, because the rat check is relatively fast, and there's already a mechanism to ignore its results. Even if we were able to come to consensus on defaulting rat.ignoreErrors to true, I'd still be opposed to the added profiles and property to control that profile, due to this added complexity with almost no utility. pom.xml <https://reviews.apache.org/r/23391/#comment83725> -1 Ensuring licenses get checked when new code is added (not just at release time) is too important of a legal requirement to bypass by default. In my view, it absolutely should run as often as possible whenever a change is made, and errors should disrupt the build, so they will be taken seriously. Even the rat documentation strongly recommends doing this, and I don't think a compelling case has been made to override that recommendation. - Christopher Tubbs On July 10, 2014, 4:34 a.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23391/ > ----------------------------------------------------------- > > (Updated July 10, 2014, 4:34 a.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2986 > https://issues.apache.org/jira/browse/ACCUMULO-2986 > > > Repository: accumulo > > > Description > ------- > > * puts rat plugin into profile > * activates profile by default > * ignores rat errrors by default > > > Diffs > ----- > > pom.xml 2bc87cf082dfeb7bfe1a3fac1fe4fba1eaa87edd > > Diff: https://reviews.apache.org/r/23391/diff/ > > > Testing > ------- > > verified rat warnings and failures given move from master -> 1.6.1-SNAPSHOT > branch with no definitions, -Drat.skip=true, -Drat.skip=false, > -Drat.ignoreErrors=true, and profile to check errors in ~/.m2/settings.xml > > > Thanks, > > Sean Busbey > >
