Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/16#discussion_r18073784
  
    --- Diff: 
server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java ---
    @@ -261,7 +263,8 @@ private static String decommisionedTabletDir(ZooLock 
zooLock, VolumeManager vm,
           throw new IllegalArgumentException("Unexpected table dir " + dir);
         }
     
    -    Path newDir = new Path(vm.choose(ServerConstants.getTablesDirs()) + 
"/" + dir.getParent().getName() + "/" + dir.getName());
    +    Path newDir = new 
Path(vm.choose(Optional.of(extent.getTableId().toString()), 
ServerConstants.getTablesDirs()) + "/tables/" + dir.getParent().getName()
    --- End diff --
    
    You added an extra "tables" to the constructed `Path`. Was that 
intentional? Doesn't `ServerConstants.getTablesDirs()` give this to you already?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to