Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/16#discussion_r18073838
  
    --- Diff: 
server/master/src/main/java/org/apache/accumulo/master/Master.java ---
    @@ -248,7 +249,7 @@ private void moveRootTabletToRootTable(IZooReaderWriter 
zoo) throws Exception {
         if (!zoo.exists(dirZPath)) {
           Path oldPath = fs.getFullPath(FileType.TABLE, "/" + MetadataTable.ID 
+ "/root_tablet");
           if (fs.exists(oldPath)) {
    -        String newPath = fs.choose(ServerConstants.getTablesDirs()) + "/" 
+ RootTable.ID;
    +        String newPath = fs.choose(Optional.of(RootTable.ID), 
ServerConstants.getTablesDirs()) + "/tables/" + RootTable.ID;
    --- End diff --
    
    Oh, you do provide `RootTable.ID` down here. Definitely choose one or the 
other. The former seems like it might be an omission?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to