----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26514/#review56418 -----------------------------------------------------------
I didn't comment on all of the occurrences, but we shouldn't have any bare Strings referring to HDFS paths. We should have constants for them (which I believe we do somewhere) and (even better) some builders for the common cases. server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java <https://reviews.apache.org/r/26514/#comment96696> We should have a constants for "/tables". server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java <https://reviews.apache.org/r/26514/#comment96697> We should have a constants for "/tables", "/table_info" and "/default_tablet" server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java <https://reviews.apache.org/r/26514/#comment96698> "/wal" should have a constant. Even better, a builder method. - Josh Elser On Oct. 9, 2014, 8:08 p.m., Jenna Huston wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26514/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 8:08 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3181 > https://issues.apache.org/jira/browse/ACCUMULO-3181 > > > Repository: accumulo > > > Description > ------- > > Delayed adding paths to volume options until after a volume is chosen. > > > Diffs > ----- > > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java > c87074b > server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java > 5cbffc3 > server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java > 0f7ac22 > > server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java > f978439 > > server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java > b8e7113 > server/master/src/main/java/org/apache/accumulo/master/Master.java 2f04922 > > server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java > 0a3d1d0 > > server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java > 5b64053 > server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java > 2bd0b47 > > Diff: https://reviews.apache.org/r/26514/diff/ > > > Testing > ------- > > Ran existing VolumeIT. > > > Thanks, > > Jenna Huston > >
