> On Oct. 21, 2014, 4:27 p.m., kturner wrote: > > server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java, > > line 82 > > <https://reviews.apache.org/r/26514/diff/3/?file=725859#file725859line82> > > > > this seems like the only code that called > > ServerConstants.getTemporaryDirs(). So I think the method can be removed > > from server constants. Not sure about the other methods in server > > constants that were being used w/ choose(), but could just try removing > > them and see if causes compile errors.
I could get rid of ServerConstants.getTemporaryDirs(), but the rest of them were in use elsewhere. - Jenna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26514/#review57599 ----------------------------------------------------------- On Oct. 20, 2014, 4:59 p.m., Jenna Huston wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26514/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2014, 4:59 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3181 > https://issues.apache.org/jira/browse/ACCUMULO-3181 > > > Repository: accumulo > > > Description > ------- > > Delayed adding paths to volume options until after a volume is chosen. > > > Diffs > ----- > > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java > c87074b > server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java > 5cbffc3 > server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java > 0f7ac22 > > server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java > f978439 > > server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java > b8e7113 > server/master/src/main/java/org/apache/accumulo/master/Master.java 2f04922 > > server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java > 0a3d1d0 > > server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java > 5b64053 > server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java > 2bd0b47 > > Diff: https://reviews.apache.org/r/26514/diff/ > > > Testing > ------- > > Ran existing VolumeIT. > > > Thanks, > > Jenna Huston > >
