> On Oct. 22, 2014, 5:20 a.m., Sean Busbey wrote:
> > server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java, 
> > lines 308-309
> > <https://reviews.apache.org/r/26514/diff/5/?file=727602#file727602line308>
> >
> >     can these two really be on different volumes?
> >     
> >     if not, we shouldn't rely on the volumemanager to be coincidentally 
> > return the same twice.
> 
> Jenna Huston wrote:
>     I think this is ok since it was like that before I changed anything, but 
> I don't know for sure.

Its choosing the initial dirs for two different metadata tablets.  From 
Accumulo's perspective, its ok for each metadata table to have a different 
volume.  There may be operational reasons to avoid this, I think thats why 
Christopher wanted the configurable volume chooser to work as early as possible.


- kturner


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26514/#review57745
-----------------------------------------------------------


On Oct. 21, 2014, 6:25 p.m., Jenna Huston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26514/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 6:25 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3181
>     https://issues.apache.org/jira/browse/ACCUMULO-3181
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Delayed adding paths to volume options until after a volume is chosen.
> 
> 
> Diffs
> -----
> 
>   server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 
> 10a864c 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 
> c87074b 
>   server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 
> fcecc37 
>   server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 
> 0f7ac22 
>   
> server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java
>  f908d25 
>   
> server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java
>  b8e7113 
>   server/master/src/main/java/org/apache/accumulo/master/Master.java f894afc 
>   
> server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java
>  0a3d1d0 
>   
> server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java
>  5b64053 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java 
> 2bd0b47 
> 
> Diff: https://reviews.apache.org/r/26514/diff/
> 
> 
> Testing
> -------
> 
> Ran existing VolumeIT.
> 
> 
> Thanks,
> 
> Jenna Huston
> 
>

Reply via email to