Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/51#discussion_r44494260
  
    --- Diff: 
core/src/main/java/org/apache/accumulo/core/client/impl/ScannerOptions.java ---
    @@ -244,4 +247,20 @@ public void setBatchTimeout(long timeout, TimeUnit 
timeUnit) {
       public long getBatchTimeout(TimeUnit timeUnit) {
         return timeUnit.convert(batchTimeOut, TimeUnit.MILLISECONDS);
       }
    +
    +  @Override
    +  public void setContext(String context) {
    +    this.context = context;
    --- End diff --
    
    My thinking is there is no way to distinguish between a user accidentally 
passing null when they did not mean to and a user trying to clear the context.  
However if we do not accept null (users must call clearContext insead), then we 
can always detect the case where a user accidentally passes null and fail fast. 
  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to