Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/51#discussion_r44564137
  
    --- Diff: 
core/src/main/java/org/apache/accumulo/core/iterators/IteratorUtil.java ---
    @@ -235,10 +231,26 @@ public static String findIterator(IteratorScope 
scope, String className, Accumul
             options.putAll(entry.getValue());
           }
         }
    +  }
     
    +  public static <K extends WritableComparable<?>,V extends Writable> 
SortedKeyValueIterator<K,V> loadIterators(IteratorScope scope,
    +      SortedKeyValueIterator<K,V> source, KeyExtent extent, 
AccumuloConfiguration conf, List<IterInfo> ssiList, 
Map<String,Map<String,String>> ssio,
    +      IteratorEnvironment env, boolean useAccumuloClassLoader) throws 
IOException {
    +    List<IterInfo> iters = new ArrayList<IterInfo>(ssiList);
    +    Map<String,Map<String,String>> allOptions = new 
HashMap<String,Map<String,String>>();
    +    parseIteratorConfiguration(scope, iters, ssio, allOptions, conf);
         return loadIterators(source, iters, allOptions, env, 
useAccumuloClassLoader, conf.get(Property.TABLE_CLASSPATH));
       }
     
    +  public static <K extends WritableComparable<?>,V extends Writable> 
SortedKeyValueIterator<K,V> loadIterators(IteratorScope scope,
    +      SortedKeyValueIterator<K,V> source, KeyExtent extent, 
AccumuloConfiguration conf, List<IterInfo> ssiList, 
Map<String,Map<String,String>> ssio,
    +      IteratorEnvironment env, boolean useAccumuloClassLoader, String 
context) throws IOException {
    +    List<IterInfo> iters = new ArrayList<IterInfo>(ssiList);
    --- End diff --
    
    seems duplicative to the method with the same name above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to