Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/51#discussion_r44565658
--- Diff:
test/src/main/java/org/apache/accumulo/test/functional/ScannerContextIT.java ---
@@ -0,0 +1,227 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.accumulo.test.functional;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+
+import java.util.Collections;
+import java.util.Iterator;
+import java.util.Map.Entry;
+
+import org.apache.accumulo.core.client.BatchScanner;
+import org.apache.accumulo.core.client.BatchWriter;
+import org.apache.accumulo.core.client.BatchWriterConfig;
+import org.apache.accumulo.core.client.Connector;
+import org.apache.accumulo.core.client.IteratorSetting;
+import org.apache.accumulo.core.client.Scanner;
+import org.apache.accumulo.core.conf.Property;
+import org.apache.accumulo.core.data.Key;
+import org.apache.accumulo.core.data.Mutation;
+import org.apache.accumulo.core.data.Range;
+import org.apache.accumulo.core.data.Value;
+import org.apache.accumulo.core.security.Authorizations;
+import org.apache.accumulo.core.util.CachedConfiguration;
+import org.apache.accumulo.fate.util.UtilWaitThread;
+import org.apache.accumulo.harness.AccumuloClusterHarness;
+import org.apache.accumulo.minicluster.impl.MiniAccumuloClusterImpl;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.hamcrest.CoreMatchers;
+import org.junit.Assume;
+import org.junit.Before;
+import org.junit.Test;
+
+public class ScannerContextIT extends AccumuloClusterHarness {
+
+ private static final String CONTEXT =
ScannerContextIT.class.getSimpleName();
+ private static final String CONTEXT_PROPERTY =
Property.VFS_CONTEXT_CLASSPATH_PROPERTY + CONTEXT;
+ private static final String CONTEXT_DIR = "file:///tmp";
+ private static final String CONTEXT_CLASSPATH = CONTEXT_DIR +
"/Test.jar";
+ private static int ITERATIONS = 10;
+
+ @Override
+ protected int defaultTimeoutSeconds() {
+ return 2 * 60;
+ }
+
+ @Before
+ public void checkCluster() {
+ Assume.assumeThat(getClusterType(), CoreMatchers.is(ClusterType.MINI));
+ MiniAccumuloClusterImpl mac = (MiniAccumuloClusterImpl) getCluster();
+ }
+
+ @Test
+ public void test() throws Exception {
+ // Copy the TestIterators jar to tmp
+ FileSystem fs = FileSystem.get(CachedConfiguration.getInstance());
+ Path srcPath = new Path(System.getProperty("user.dir") +
"/target/TestIterators-tests.jar");
+ Path dstPath = new Path(CONTEXT_DIR + "/Test.jar");
+ fs.copyFromLocalFile(srcPath, dstPath);
+ // Sleep to ensure jar change gets picked up
+ UtilWaitThread.sleep(5000);
+
+ try {
+ Connector c = getConnector();
+ // Set the classloader context property on the table to point to the
TestIterators jar file.
+ c.instanceOperations().setProperty(CONTEXT_PROPERTY,
CONTEXT_CLASSPATH);
+
+ // Insert rows with the word "Test" in the value.
+ String tableName = getUniqueNames(1)[0];
+ c.tableOperations().create(tableName);
+ BatchWriter bw = c.createBatchWriter(tableName, new
BatchWriterConfig());
+ for (int i = 0; i < ITERATIONS; i++) {
+ Mutation m = new Mutation("row" + i);
+ m.put("cf", "col1", "Test");
+ bw.addMutation(m);
+ }
+ bw.close();
+ // Ensure that we can get the data back
+ scanCheck(c, tableName, null, null, "Test");
+ batchCheck(c, tableName, null, null, "Test");
+
+ // This iterator is in the TestIterators jar file
+ IteratorSetting cfg = new IteratorSetting(1, "reverse",
"org.apache.accumulo.test.functional.ValueReversingIterator");
+
+ // Check that ValueReversingIterator is not already on the classpath
by not setting the context. This should fail.
+ try {
+ scanCheck(c, tableName, cfg, null, "tseT");
+ fail("This should have failed because context was not set");
+ } catch (Exception e) {
+ // Do nothing, this should fail as the classloader context is not
set.
+ }
+ try {
+ batchCheck(c, tableName, cfg, null, "tseT");
+ fail("This should have failed because context was not set");
+ } catch (Exception e) {
+ // Do nothing, this should fail as the classloader context is not
set.
+ }
+
+ // Ensure that the value is reversed using the iterator config and
classloader context
+ scanCheck(c, tableName, cfg, CONTEXT, "tseT");
+ batchCheck(c, tableName, cfg, CONTEXT, "tseT");
+ } finally {
+ // Delete file in tmp
+ fs.delete(dstPath, true);
+ }
+
+ }
+
+ @Test
+ public void testScanContextOverridesTableContext() throws Exception {
+ // Copy the TestIterators jar to tmp
+ FileSystem fs = FileSystem.get(CachedConfiguration.getInstance());
--- End diff --
This is repeated. Do it once in a before?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
