For those interested in following along with the PreCommit work, see https://issues.apache.org/jira/browse/YETUS-263

A "personality", in Yetus parlance, defines the the tests/checks that PreCommit will run against Accumulo. For us, it's pretty simple. The personality I provided on YETUS-263 will, for a patch/changeset run:

* Checkstyle
* Findbugs
* RAT check
* @author javadoc check
* Some extra whitespace
* All unit tests (not just in the module where changes were made)
* Compiler warnings
* Javadoc warnings
* Presence of new unit tests

One already built in feature that I didn't wire up is ShellCheck for our shell scripts. This will require a bit of fixing on our end first.

For more general information, Chris Nauroth wrote up a good explanation for adopting the same approach in ZooKeeper (and did a much better job than me http://mail-archives.apache.org/mod_mbox/zookeeper-dev/201512.mbox/%3CD291EB3B.3504A%25cnauroth%40hortonworks.com%3E).

Anywho, nothing really changing here yet (I'm hoping Sean will write up instructions about how to configure the Jenkins job for us https://issues.apache.org/jira/browse/YETUS-245). That would signify a step for Accumulo specifically. Until then, this is just an FYI.

- Josh

Reply via email to