Github user joshelser commented on the pull request:
https://github.com/apache/accumulo/pull/63#issuecomment-170102128
> I wish I could see the files side-by-side in GitHub to review, but the
file was moved in addition to being updated, so GitHub is confused. :(
Blarg. The crux of things is that the method `createFrameBuffer` exists on
`SelectAcceptThread` *not* `THsHaServer` (or in its lineage). The easiest hack
I saw was to inject our own custom `SelectAcceptThread`, akin to what we were
doing with the `FrameBuffer`. Eric messed up the changes and used the
`AsyncFrameBuffer` interface instead of the `FrameBuffer` class in his original
commit too (we don't use the Async Processors -- our rpc system is blocking).
I think that's the best synopsis of what's going on here. I would also be
OK with throwing in the thrift warning. As always, we *never* want to
willy-nilly update libthrift versions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
