Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/143#discussion_r76692450
--- Diff:
server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java
---
@@ -80,10 +80,10 @@
public class GarbageCollectWriteAheadLogs {
private static final Logger log =
LoggerFactory.getLogger(GarbageCollectWriteAheadLogs.class);
+ private static final Map<HostAndPort,Long> firstSeenDead = new
HashMap<HostAndPort,Long>();
private final AccumuloServerContext context;
private final VolumeManager fs;
- private final Map<HostAndPort,Long> firstSeenDead = new
HashMap<HostAndPort,Long>();
--- End diff --
+1 to capturing this in an integration test.
You might be able to [use an existing
test](https://github.com/apache/accumulo/blob/1.7/test/src/test/java/org/apache/accumulo/test/functional/RestartIT.java)
as a starting point. There are test bindings which will make starting/stopping
services simple. The tricky point will be identifying a WAL for a tserver
before stopping it and then verifying that it does not get deleted after an
amount of time greater than the GC's period.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
